Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat (mx): PTQ MX + Float support #1010

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Feat (mx): PTQ MX + Float support #1010

merged 3 commits into from
Sep 5, 2024

Conversation

Giuseppe5
Copy link
Collaborator

@Giuseppe5 Giuseppe5 commented Aug 27, 2024 •
edited
Loading

Depends on #1013

@Giuseppe5 Giuseppe5 changed the title Ptq fp Feat (mx): Support for GPTQ and automatic group_dim for layerwise Aug 27, 2024
@Giuseppe5 Giuseppe5 changed the title Feat (mx): Support for GPTQ and automatic group_dim for layerwise Feat (mx): PTQ MX + Float support Aug 28, 2024
nickfraser
nickfraser reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just needs a rebase + README help regeneration.

src/brevitas_examples/imagenet_classification/ptq/ptq_evaluate.py Show resolved Hide resolved
@nickfraser nickfraser self-requested a review September 5, 2024 09:02
@nickfraser
Copy link
Collaborator

As before, failing check passes when run locally on a windows machine.

@nickfraser nickfraser merged commit b889bb2 into Xilinx:dev Sep 5, 2024
336 of 337 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser Awaiting requested review from nickfraser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @nickfraser