Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpProj Module and Dead Codes in torch_resnet_cspn_nyu.py #46

Open
I3aer opened this issue Mar 17, 2021 · 0 comments
Open

UpProj Module and Dead Codes in torch_resnet_cspn_nyu.py #46

I3aer opened this issue Mar 17, 2021 · 0 comments

Comments

@I3aer
Copy link

I3aer commented Mar 17, 2021

Hi,

I checked the "torch_resnet_cspn_nyu.py" to understand how you implemented the depth network before CSPN module. I found many dead codes in that file. For example, could you please tell me where you use those self.up_proj_layer(1/2/3/4) in forward function? In addition, when I check the paper the implementation of UpProj is not same as that depicted in Fig. 5 (see, conference paper)? After up-sampling by self._up_pool (object of Unpool), the output is used by the shortcut layer. However, the figure shows that there are conv, BN and Relu before feeding the output of the upsample to the shortcut. Could you please clarify those points for me?

Thanks for providing the code. I appreciate it. However, I think that the code could have been written far better to help people working in academic area and understand your idea better.

Thank you,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant