Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency between moco v3's usage as a backbone by this paper and by official moco repo #46

Open
TumVink opened this issue Apr 17, 2024 · 1 comment

Comments

@TumVink
Copy link

TumVink commented Apr 17, 2024

Heyy,

I wanted to share my observations regarding the correct usage of moco v3 as a backbone, as reported by the moco official repository, as well as a potential inconsistency in the repository.

image

In the file main_lincls.py of the moco v3 repository, the module self.base_encoder.head is removed assuming that ViT is being used as the backbone. However, in the file get_features_mocov3.py of the same repository, the fc layer self.base_encoder is still present in the backbone, which should be nn.Identity() in this case, as did to Ctranspath.

I just wanted to share my observations and this does not indicate any doubts towards the experiment results. In fact, I really enjoyed this work a lot.

I am open to have a discussion with followers.

@Xiyue-Wang
Copy link
Owner

Yes, you can also remove base_encoder.head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants