fix, stop chapters download when mangafox page doesn't contain images. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xonshiz
requested changes
Jun 14, 2018
comic_dl/sites/mangaFox.py
Outdated
| @@ -37,11 +37,21 @@ def name_cleaner(self, url): | |||
| def single_chapter(self, comic_url, comic_name, download_directory, conversion, delete_files): | |||
| source, cookies_main = globalFunctions.GlobalFunctions().page_downloader(manga_url=comic_url) | |||
|
|
|||
There was a problem hiding this comment.
Thanks for the PR. But, could you please author your code? like "@darodi for fixing #IssueNumber". Makes it easier to see which section was worked on by whom and what it fixes/adds/updates.
There was a problem hiding this comment.
done, the commit message has been changed.
darodi
added a commit
to darodi/comic-dl
that referenced
this pull request
Jun 14, 2018
…sn't contain images.
darodi
added a commit
to darodi/comic-dl
that referenced
this pull request
Jun 14, 2018
…sn't contain images.
darodi
added a commit
to darodi/comic-dl
that referenced
this pull request
Jun 14, 2018
…sn't contain images.
darodi
added a commit
to darodi/comic-dl
that referenced
this pull request
Jul 2, 2018
…page doesn't contain images.
darodi
added a commit
to darodi/comic-dl
that referenced
this pull request
Jul 2, 2018
…sn't contain images.
…sn't contain images.
…sn't contain images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example:
http://fanfox.net/manga/gunnm_mars_chronicle/c029.1/1.html
in that case, when using
__main__.py -acomic-dl exits with an error.
I made changes to stop the download for that manga but continue processing the remaining comics/mangas