Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download quality not used #51

Closed
dsanchezseco opened this issue Nov 15, 2017 · 7 comments
Closed

Download quality not used #51

dsanchezseco opened this issue Nov 15, 2017 · 7 comments
Assignees
Labels

Comments

@dsanchezseco
Copy link
Collaborator

It's seems that is a ctrl+c/v typo -> comic_dl.py line 69

Here's the snippet of code.

[...]
            if not args.convert:
                args.convert = ["None"]
            if not args.keep:
                args.keep = ["True"]
            if not args.keep:
                args.keep = ["Best"]

            start_time = time.time()
[...]
@Xonshiz Xonshiz self-assigned this Nov 15, 2017
@Xonshiz Xonshiz added the bug label Nov 15, 2017
@Xonshiz
Copy link
Owner

Xonshiz commented Nov 15, 2017

Nice catch! I'll fix this up tomorrow.

@dsanchezseco
Copy link
Collaborator Author

dsanchezseco commented Nov 15, 2017

maybe i do a pull request later. i'm also trying to figure what's the problem with conversion on mac/linux. #bugIncoming

@Xonshiz
Copy link
Owner

Xonshiz commented Nov 15, 2017

That'll be great then. Damn conversion not working on mac/linux? I think I need to set up some virtual env here on my end as well.

@dsanchezseco
Copy link
Collaborator Author

dsanchezseco commented Nov 15, 2017

The principal suspect is

        path_breaker = str(old_path).split("\\")

mac/linux use / as separator opposite to \ of Win

@Xonshiz
Copy link
Owner

Xonshiz commented Nov 15, 2017

Ah, I see. I had my doubts while putting those in the code. Cross-platform compatibility can be a bitch sometimes. I'll look into this later tomorrow and try to fix it quick...

@Xonshiz
Copy link
Owner

Xonshiz commented Nov 15, 2017

Thanks for the PR, @dsanchezseco . Please make a new Issue for the path problem.

@dsanchezseco
Copy link
Collaborator Author

I'm on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants