-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox html5 clipboard sync is... confusing. #12
Comments
2019-10-17 19:19:29: afarr commented
|
See also Xpra-org/xpra#2450, the new clipboard code comes from Xpra-org/xpra#812 |
DOH. |
Re-opening because we need to handle Firefox better: either request the permissions we need (not sure if this requires an "extension" as the MDN page seems to imply), or at least telling the user something more useful. |
2019-10-29 19:47:41: afarr commented
|
DOH. Xpra-org/xpra@c1cbe4d was incomplete, Xpra-org/xpra@dc216d5 fixes that. I'm pretty sure I had tested that, I even made some MS Edge and IE11 fixes: Xpra-org/xpra#1844#comment:13. How did this work before?? Note: we poll for clipboard content changes when we receive any click events, but since we use the new asynchonous API, it is possible that the application will receive its paste event (from the menu click) before we've had a chance to update the clipboard contents... |
2019-11-12 22:12:51: afarr commented
|
As per Xpra-org/xpra#1844, this works for me with both Firefox and Chrome, on Linux and win32, but only if I connect over https and grant clipboard permissions when asked.
I'm not seeing this particular oddity. Xpra-org/xpra@a09530b just fixed what looked like a minor warning, but this seems to have helped prevent things from getting wedged: we just ignore invalid clipboard notification messages. |
2019-11-14 00:43:11: afarr commented
|
2019-11-14 12:29:32: antoine commented
|
2019-11-14 12:45:03: antoine commented
|
2019-11-14 22:12:50: afarr commented
|
2019-11-14 22:47:06: afarr commented
|
2019-11-14 22:56:31: afarr commented
|
2019-11-14 23:43:13: afarr commented
|
This ticket is getting hard to follow, and it is about to get worse as I've just a hit a new problem, which may or may not be related. Anyway, to make a summary of the issues above:
Looks like you forgot to include the "clipboard" debugging client side. |
2019-11-18 22:43:59: afarr commented
|
2019-11-18 23:15:24: afarr commented
|
2019-11-19 11:29:20: antoine uploaded file
|
I've spent longer than I'll admit staring at this log (thank you for providing that) wondering why they're different, in both cases:
After that, when things don't work:
When things do work:
Thoughts:
|
Fixes:
And then I did some more testing and I finally managed to reproduce the problem semi reliably, and it really looks to me like comment:13 is the solution: with a value of 50ms or above, the problems go away! 50ms delay is almost acceptable, but ideally I would like to only apply the delay when we know that a paste event is likely to be due: when we get a control-v, or when we get a click. |
2019-11-20 00:25:05: afarr commented
|
As of Xpra-org/xpra@e354f68, the delay is constified as |
Damn, forgot to hit submit - this bit is from yesterday: Xpra-org/xpra@e354f68 implements a 100ms delay in the html5 client, it is only used when we know / think that a clipboard paste may be in progress. The rest of the time, key events and clicks are sent without delay. (the code is not perfect, but it is relatively simple and the corner cases should be nearly impossible to hit in normal day to day use) Except... I think one of those earlier changes has caused a regression with X11 clients (the clipboard contents remained stuck on an old value), but now that I'm trying to reproduce it, things seem to work fine again, obviously. @afarr: I've uploaded new beta 4.0 builds, can you try those? |
2019-11-20 23:22:06: afarr commented
|
2019-11-20 23:27:42: afarr commented
|
Good, and since I can't seem to be able to fix it... I'm lowering the priority. |
Clipboard support has been updated and fixed a few times since 2019.. let's hope this is fixed. |
Issue migrated from trac ticket # 2452
component: html5 | priority: major | keywords: clipboard
2019-10-17 19:12:20: afarr created the issue
The text was updated successfully, but these errors were encountered: