switch to gstreamer 1.6.x on osx

[totaam]

Issue migrated from trac ticket # 1069

component: platforms | priority: blocker | resolution: fixed | keywords: osx sound

2015-12-31 05:57:49: antoine created the issue

---

As can be seen here: [http://gstreamer.freedesktop.org/src/gstreamer/], the 1.4.x branch has been abandoned over a year ago.
We should switch to the currently supported stable branch.

[totaam]

2016-03-28 03:58:59: antoine changed priority from minor to critical

[totaam]

2016-03-28 03:58:59: antoine commented

---

Please include details of what breaks with this change so we can try to fix it.
Sticking with the 1.4 branch is causing problems (see r12249), and even the 1.6 branch is no longer supported as 1.8 is out: [https://gstreamer.freedesktop.org/releases/gstreamer/1.8.0.html].

[totaam]

2016-04-16 04:25:55: antoine changed priority from critical to blocker

[totaam]

2016-04-16 04:25:55: antoine commented

---

Couldn't wait any longer for 0.17, so done in r12390.

I hit this trivial bug in gst-plugins-good-1.0:

(...)
In file included from gstosxcoreaudio.c:35:
gstosxcoreaudiohal.c: In function '_audio_system_get_default_device':
gstosxcoreaudiohal.c:62: warning: ISO C90 forbids mixed declarations and code
gstosxcoreaudiohal.c: In function '_audio_device_is_alive':
gstosxcoreaudiohal.c:126: warning: ISO C90 forbids mixed declarations and code
gstosxcoreaudiohal.c: In function '_audio_device_get_name':
gstosxcoreaudiohal.c:272: warning: ISO C90 forbids mixed declarations and code
gstosxcoreaudio.c: In function 'gst_core_audio_asbd_to_caps':
gstosxcoreaudio.c:419: error: 'kLinearPCMFormatFlagsSampleFractionMask' undeclared (first use in this function)
gstosxcoreaudio.c:419: error: (Each undeclared identifier is reported only once
gstosxcoreaudio.c:419: error: for each function it appears in.)
make[3]: *** [libgstosxaudio_la-gstosxcoreaudio.lo] Error 1

Fixed by patching the source file with:

#ifndef kLinearPCMFormatFlagsSampleFractionShift
#define kLinearPCMFormatFlagsSampleFractionShift 7
#endif
#ifndef kLinearPCMFormatFlagsSampleFractionMask
#define kLinearPCMFormatFlagsSampleFractionMask (0x3F << kLinearPCMFormatFlagsSampleFractionShift)
#endif

@smo: Is this the error you encountered? Please always record them. If so, please just merge this as a patch to the moduleset and re-assign to afarr for sound testing. I don't expect major regressions by switching from gstreamer 1.4.x to 1.6.x, but who knows.
(briefly tested with opus and mp3)

We should switch to 1.8 for 0.18: see #1168.

[totaam]

2016-05-04 23:21:23: smo changed owner from smo to afarr

[totaam]

2016-05-04 23:21:23: smo commented

---

I had the same error and created a patch r12528

forced a recompile by removing the source directory and doing

jhbuild buildone --force gst-plugins-good-1.0

Built successfully now needs to be tested.

[totaam]

2016-05-05 01:03:54: afarr changed status from new to closed

[totaam]

2016-05-05 01:03:54: afarr set resolution to fixed

[totaam]

2016-05-05 01:03:54: afarr commented

---

Installed and tested osx 0.17.0 12465 client (from /beta repo) against 0.17.1 r12453 fedora 23 server (Session Info confirms GStreamer 1.6.4.0).

Sound is good quality, av-sync seems to be within .1 s (at the very outside... looks perfect to my ears).

Disconnecting/reconnecting; pausing/unpausing sound sources; using the application menu to turn speakers off/on; no problems to be found.

Sounds fixed to me. I'll take the liberty of closing.