notification enhancements: icons, etc

[totaam]

Issue migrated from trac ticket # 1492

component: core | priority: major | resolution: fixed

2017-04-09 12:07:03: antoine created the issue

---

See desktop notification specification.

The icons could be png encoded.
The actions would require us to check that the client supports the feature before we expose the server-side capability.

[totaam]

2017-11-14 14:09:07: antoine commented

---

See #1688, #1375

[totaam]

2017-11-26 13:37:09: antoine changed status from new to assigned

[totaam]

2018-01-07 05:56:17: antoine edited the issue description

[totaam]

2018-01-07 05:56:17: antoine commented

---

new spec link (had gone 404)

[totaam]

2018-01-07 09:02:08: antoine commented

---

Important bug fix in r17933: send icon data not path (which is often at best meaningless for a remote client).
Minimal backport in 17934.

[totaam]

2018-01-07 12:45:56: antoine commented

---

More related changes:

• r17935: html5 client support
• r17936: fix usage via "xpra control"
• r17938 + r17940 + r17941: make win32 code reusable, win32 support
  (with py3k fix)

To test:

notify-send 'Hello world!' 'This is an example notification.' \
    --icon=/usr/share/xpra/icons/xpra.png

Already tested with:

• gnome shell, with both the python2 and the python3 client
• html5 client
• macos python2 and python3 clients (see also native OSX notifications #1305 for why we don't use the native ones), python3 client porting work recorded here: python3 gtk3 client feature parity #1717#comment:4
• win32: python2 and python3

Note: some specific desktop environment may decide to block or hide the notifications..

Moving support for notification actions to #1735.

[totaam]

2018-01-08 06:50:53: antoine changed status from assigned to new

[totaam]

2018-01-08 06:50:53: antoine changed owner from antoine to maxmylyn

[totaam]

2018-01-08 06:50:53: antoine commented

---

@maxmylyn: mostly a FYI, see comment:5.

[totaam]

2018-01-09 17:05:20: maxmylyn changed status from new to closed

[totaam]

2018-01-09 17:05:20: maxmylyn set resolution to fixed

[totaam]

2018-01-09 17:05:20: maxmylyn commented

---

Noted and closing.

[totaam]

2018-01-13 05:37:15: antoine changed title from notification enhancements: icons, actions, etc to notification enhancements: icons, etc

[totaam]

2018-01-13 05:37:15: antoine commented

---

r17973 (+r17974): the macos python3 client can now use the gtk notifier

(edit ticket title since "actions" have been moved to #1735)

[totaam]

2018-01-30 06:15:37: antoine commented

---

r18195: when we need to show actions or when we don't have a native tray to bind to, fallback to using the gtk notifier.

This helps with #1688