system-wide proxy cannot create a connection (`[Errno 9] Bad file descriptor`) #3939

goekce · 2023-07-25T14:28:36Z

I want to use the system-wide proxy to create a new Xpra session via the HTML5 client. The client fails after a timeout with connection failed, invalid address?.

Steps to reproduce the behavior:

I use the packaged xpra.service with the following exception: --ssl=off.
Open the http://SERVER_ADDR:port via browser, login

Server & client OS: ArchLinux
Server version: latest v5.0-r33870 (g27b450d87), client (HTML5 latest f133a43)

I also tried downgrading to 4.4.6. The problem does not exist in 4.4.6. I can bisect if needed.

Remarks:

I noticed that it is not possible to start a session via system-wide proxy if pam-selinux is not installed. Is SELinux required for the system-wide proxy? Maybe /etc/pam.d/xpra must be reconfigured, however this is another issue.
xpra.service uses --tcp-auth even man xpra states that --tcp-auth is deprecated and bind-tcp=0.0.0.0:14500,auth=... should be used instead. Is the notion of arguments in xpra proxy are slightly different? However I don't think using tcp-auth is related to this issue.

Server logs (auth, proxy, websocket, protocol):


2023-07-25 16:14:22,080 socktype=ws, encryption=, keyfile=''                                                                                                                                                                                                                                                                 
2023-07-25 16:14:22,080 io_thread_loop(read, ) loop starting                                                                                                                                  
2023-07-25 16:14:23,081 untilConcludes(, , , (65536,), {}) timed out, retry=socket.timeout                                                                                                                                                                                                                                                                                               
~10 times above message
2023-07-25 16:14:37,099 untilConcludes(<bound method Connection.is_active of ws socket: ::ffff:10.10.10.10, 14500, 0, 0 <- ::ffff:10.10.20.20, 51030, 0, 0>, <bound method Connection.can_retry of ws socket: <- ::ffff:10.10.20.20, 51030, 0, 0>, <built-in method recv of socket object at 0x7f99fa322980>, (65536,), {}) timed out, retry=socket.timeout

2023-07-25 16:14:37,149 SocketConnection(<socket.socket fd=11, family=10, type=1, proto=0, laddr=('::ffff:10.10.10.10', 14500, 0, 0), raddr=('::ffff:10.10.20.20', 56790, 0, 0)>, ('::ffff:10.10.10.10', 14500

56790, 0, 0), ('::ffff:10.10.20.20', 56790, 0, 0), 'tcp', None, {})

2023-07-25 16:14:37,150 Connection(('::ffff:10.10.20.20', 56790, 0, 0), 'tcp', None, {})

2023-07-25 16:14:37,150 tcp options: cork=True, nodelay=None
~10 times the untilConcludes message again
2023-07-25 16:14:53,096 flush_then_close(<bound method SocketProtocol.encode of WebSocket(ws socket: ::ffff:10.10.10.10, 14500, 0, 0 <- ::ffff:10.10.20.20, 51030, 0, 0)>, ['disconnect', 'login timeout'], <function noop at 0x7f99fc508f40>) closed=False

2023-07-25 16:14:53,096 flush_then_close: wait_for_write_lock()

2023-07-25 16:14:53,096 flush_then_close: acquired the write lock

2023-07-25 16:14:53,096 flush_then_close: queue is now empty, sending the last packet and closing

2023-07-25 16:14:53,096 packet type send alias not found for 'disconnect'

2023-07-25 16:14:53,096 sending 26 bytes without header

2023-07-25 16:14:53,096 make_wsframe_header(disconnect, 1 items) 26 bytes, ws_mask=False, header=0x821a (2 bytes)

2023-07-25 16:14:53,096 raw_write for disconnect, starting write thread

2023-07-25 16:14:53,097 io_thread_loop(write, <bound method SocketProtocol._write of WebSocket(ws socket: ::ffff:10.10.10.10, 14500, 0, 0 <- ::ffff:10.10.20.20, 51030, 0, 0)>) loop starting

2023-07-25 16:14:53,097 changed ws socket to nodelay=True

2023-07-25 16:14:53,097 flush_then_close: packet_queued() closed=False

2023-07-25 16:14:53,097 flush_then_close: wait_for_packet_sent() queue.empty()=True, closed=False

2023-07-25 16:14:53,097 close_and_release()

2023-07-25 16:14:53,098 flush_then_close(None, b'\x88\x02\x03\xe8', <function noop at 0x7f99fc508f40>) had already been called, this new request has been ignored

2023-07-25 16:14:53,098 Protocol.close(None) closed=False, connection=ws socket: ::ffff:10.10.10.10, 14500, 0, 0 <- ::ffff:10.10.20.20, 51030, 0, 0

2023-07-25 16:14:53,098 Protocol.close(None) calling <bound method SocketConnection.close of ws socket: ::ffff:10.10.10.10, 14500, 0, 0 <- ::ffff:10.10.20.20, 51030, 0, 0>

2023-07-25 16:14:53,098 ws socket: ::ffff:10.10.10.10, 14500, 0, 0 <- ::ffff:10.10.20.20, 51030, 0, 0.close() socket=<socket.socket fd=8, family=10, type=1, proto=0, laddr=('::ffff:10.10.10.10', 14500, 0, 0), raddr=('::ffff:10.10.20.20', 51030, 0, 0)>

2023-07-25 16:14:53,098 ws socket: ::ffff:10.10.10.10, 14500, 0, 0 <- ::ffff:10.10.20.20, 51030, 0, 0.close() done

2023-07-25 16:14:53,098 terminate_queue_threads()

2023-07-25 16:14:53,098 Protocol.close(None) done

2023-07-25 16:14:53,098 io_thread_loop(write, <bound method SocketProtocol._write of WebSocket(None)>) loop ended, closed=True

2023-07-25 16:14:53,121 can_retry: <class 'OSError'>, args=(9, 'Bad file descriptor'), errno=9, code=9, abort=9

2023-07-25 16:14:53,121 None closed in read loop

Traceback (most recent call last):

File "/usr/lib/python3.11/site-packages/xpra/net/protocol/socket_handler.py", line 666, in _io_thread_loop

while not self._closed and callback():

^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/protocol/socket_handler.py", line 757, in _read

buf = self.con_read()

^^^^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/protocol/socket_handler.py", line 775, in con_read

return self._conn.read(self.read_buffer_size)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/bytestreams.py", line 348, in read

return self._read(self._socket.recv, n)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/bytestreams.py", line 164, in _read

r = self.untilConcludes(*args)

^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/bytestreams.py", line 149, in untilConcludes

return untilConcludes(self.is_active, self.can_retry, *args)

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/bytestreams.py", line 85, in untilConcludes

retry = can_retry_cb(e)

^^^^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/bytestreams.py", line 146, in can_retry

return can_retry(e)

^^^^^^^^^^^^

File "/usr/lib/python3.11/site-packages/xpra/net/bytestreams.py", line 75, in can_retry

raise ConnectionClosedException(e) from None

xpra.net.common.ConnectionClosedException: [Errno 9] Bad file descriptor

2023-07-25 16:14:58,102 close_and_release()

The text was updated successfully, but these errors were encountered:

totaam · 2023-07-25T15:23:50Z

Please try first on a supported OS like Fedora, I do not have ArchLinux to test.

goekce · 2023-07-25T15:50:25Z

Oh, I did not know that ArchLinux is not supported. Does this mean that you are not interested in helping ArchLinux users either?

I don't have have any experience with Fedora ecosystem. If you are interested I can prepare a Docker image or bisect.

totaam · 2023-07-25T15:53:45Z

Oh, I did not know that ArchLinux is not supported.

https://github.com/Xpra-org/xpra/wiki/Platforms

Does this mean that you are not interested in helping ArchLinux users either?

No it means that my "free" time is very limited: https://xpra.org/list/2023-July/002987.html
Supporting 30+ distribution variants is non starter.

goekce · 2023-07-26T10:42:58Z

I feel sorry 😐. I will open a PR after I have a rough idea where the problem could be. My OS is not supported so I want to leave space for more important issues.

Regarding project management changes:

I have been also asking myself how you handle this large project alone. I don't have experience with sustaining open source projects. What I saw in another open source project is:

Asking directly in the issue template if the person would like to contribute with a PR. (Even many people cannot contribute, this still nudges people that this is the norm or expected.)
If yes: the project maintainer roughly explains what should be done and where to look at. Then the maintainer supports the PR if needed

totaam · 2023-07-27T16:02:47Z

Interestingly, the missing attributes had been flagged in: #3930 (comment).

goekce · 2023-08-08T15:21:15Z

The Bad file descriptor error seems to be solved and the rest seems to be related to the Nginx proxy. I opened #3958 for that.

goekce added the bug Something isn't working label Jul 25, 2023

goekce closed this as completed Jul 26, 2023

This was referenced Aug 7, 2023

Authentication does not work after #259 Xpra-org/xpra-html5#260

Closed

System-wide proxy cannot create websocket connection behind Nginx #3958

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

system-wide proxy cannot create a connection (`[Errno 9] Bad file descriptor`) #3939

system-wide proxy cannot create a connection (`[Errno 9] Bad file descriptor`) #3939

goekce commented Jul 25, 2023 •

edited

Loading

totaam commented Jul 25, 2023

goekce commented Jul 25, 2023

totaam commented Jul 25, 2023 •

edited

Loading

goekce commented Jul 26, 2023

totaam commented Jul 27, 2023

goekce commented Aug 8, 2023

system-wide proxy cannot create a connection ([Errno 9] Bad file descriptor) #3939

system-wide proxy cannot create a connection ([Errno 9] Bad file descriptor) #3939

Comments

goekce commented Jul 25, 2023 • edited Loading

totaam commented Jul 25, 2023

goekce commented Jul 25, 2023

totaam commented Jul 25, 2023 • edited Loading

goekce commented Jul 26, 2023

totaam commented Jul 27, 2023

goekce commented Aug 8, 2023

system-wide proxy cannot create a connection (`[Errno 9] Bad file descriptor`) #3939

system-wide proxy cannot create a connection (`[Errno 9] Bad file descriptor`) #3939

goekce commented Jul 25, 2023 •

edited

Loading

totaam commented Jul 25, 2023 •

edited

Loading