Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict the DLLs we load on win32 to avoid those with known vulnerabilities #749

Closed
totaam opened this issue Dec 1, 2014 · 6 comments
Closed

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 1, 2014

Issue migrated from trac ticket # 749

component: client | priority: major | resolution: wontfix | keywords: win32

2014-12-01 20:28:37: antoine created the issue


For example: flac changelog: Fix CVE-2014-9028 (heap write overflow) and CVE-2014-8962 (heap read overflow) in 1.3.1

Related to:

We should at least exclude flac on win32, it would also be a good idea to inspect all the media libraries we ship and blacklist the ones that are too out of date / vulnerable (hopefully this will leave some we can still use).

@totaam
Copy link
Collaborator Author

totaam commented Dec 1, 2014

2014-12-01 20:46:09: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Dec 1, 2014

2014-12-01 20:46:09: antoine commented


r8163 avoids flac on win32 with gstreamer 0.10 - should be backported.

We now need to go through the rest of the dlls..

@totaam
Copy link
Collaborator Author

totaam commented Jan 18, 2015

2015-01-18 10:45:17: antoine commented


Backport in 8501.

@totaam
Copy link
Collaborator Author

totaam commented Feb 2, 2015

2015-02-02 09:52:53: totaam changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Feb 2, 2015

2015-02-02 09:52:53: totaam set resolution to wontfix

@totaam
Copy link
Collaborator Author

totaam commented Feb 2, 2015

2015-02-02 09:52:53: totaam commented


With the number of dlls we cannot replace since we cannot build GTK2 from source, I think it is just too hard to make the win32 safe.
We need either a native client (pure pywin32?) or use GTK3 (#640).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant