Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win32 client does not exit cleanly (again) #819

Closed
totaam opened this issue Mar 2, 2015 · 3 comments
Closed

win32 client does not exit cleanly (again) #819

totaam opened this issue Mar 2, 2015 · 3 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 2, 2015

Issue migrated from trac ticket # 819

component: client | priority: critical | resolution: fixed | keywords: win32

2015-03-02 05:52:26: antoine created the issue


Some recent change to the event handling must have caused this.
We end up not cleaning up the tray and not running all the exit cleanup callbacks.
I have also seen a GTK warning about not being able to delete a window property..
Probably some time after r8546, before r8715.
Likely changeset: r8700.

@totaam
Copy link
Collaborator Author

totaam commented Mar 2, 2015

2015-03-02 07:44:19: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Mar 2, 2015

2015-03-02 07:44:19: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Mar 2, 2015

2015-03-02 07:44:19: antoine commented


r8700 was not the cause of the problem, so I looked into SetConsoleCtrlHandler
(and Registering a Control Handler Function) and implemented in r8736 + r8739 a solution which has the added benefit of working well with GTK3! (see #640)

I was wrong about the delete window property: this one is still there!

@totaam totaam closed this as completed Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant