Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paint error with pixmap backing and mmap #857

Closed
totaam opened this issue May 12, 2015 · 6 comments
Closed

paint error with pixmap backing and mmap #857

totaam opened this issue May 12, 2015 · 6 comments

Comments

@totaam
Copy link
Collaborator

totaam commented May 12, 2015

Issue migrated from trac ticket # 857

component: client | priority: blocker | resolution: fixed

2015-05-12 08:29:12: antoine created the issue


process_draw 1 bytes for window 1 using mmap encoding with options={'rgb_format': 'RGB'}
draw_region(0, 0, 499, 316, mmap, 1 bytes, 1497, {'rgb_format': 'RGB'}, [<function record_decode_time at 0x7facbd53dcf8>, <function after_draw_refresh at 0x7facb4ad2b18>])
do_paint_rgb24 error
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/xpra/client/window_backing_base.py", line 274, in do_paint_rgb24
    success = (self._backing is not None) and self._do_paint_rgb24(img_data, x, y, width, height, rowstride, options)
  File "/usr/lib64/python2.7/site-packages/xpra/client/gtk2/pixmap_backing.py", line 78, in _do_paint_rgb24
    self._backing.draw_rgb_image(gc, x, y, width, height, gdk.RGB_DITHER_NONE, img_data, rowstride)
IndexError: rgb_buf is not large enough

Probably another case of #90 causing problems elsewhere.

@totaam
Copy link
Collaborator Author

totaam commented May 12, 2015

2015-05-12 08:30:48: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented May 12, 2015

2015-05-12 08:30:48: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented May 12, 2015

2015-05-12 08:30:48: antoine changed title from paint error with pixmap backing to paint error with pixmap backing and mmap

@totaam
Copy link
Collaborator Author

totaam commented May 12, 2015

2015-05-12 09:02:43: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented May 12, 2015

2015-05-12 09:02:43: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented May 12, 2015

2015-05-12 09:02:43: antoine commented


That was caused by the following call:

memoryview_to_bytes(<class 'xpra.net.mmap_pipe.c_char_Array_473052'>)

Which got converted to a string... r9311 fixes that. (backport to v0.15.x in 9312).

@totaam totaam closed this as completed May 12, 2015
@totaam totaam added the v0.15.x label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant