Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: progress bar text turns blue #1508

Closed
YamatoSecurity opened this issue Nov 25, 2024 · 0 comments · Fixed by #1509
Closed

Bug: progress bar text turns blue #1508

YamatoSecurity opened this issue Nov 25, 2024 · 0 comments · Fixed by #1509
Assignees
Labels
bug Something isn't working
Milestone

Comments

@YamatoSecurity
Copy link
Collaborator

For the csv-timeline and json-timeline commands, when the results are printed to standard output, I don't think we should output the progress bar as we already have the Scanning finished message being displayed. (Note: this only applies to the default settings where the events are not being sorted. When -s is used to sort the events, then we should still show the progress bar)

I just noticed that the color of the progress bar will be affected with csv-timeline:

Screenshot 2024-11-25 at 19 41 44

So I would like to not display the progress bar at the end when -o is not being used.

Ex: ./target/release/hayabusa csv-timeline -d ../hayabusa-sample-evtx -w -r ../hayabusa-rules/hayabusa/sysmon/Sysmon_1_ProcExec_High_LOLBAS-Rename.yml

@fukusuket Could I ask you to do this one? After this issue is complete, I am thinking about releasing v2.19.0.

If is it difficult to disable the progress bar when -s is not used in csv-timeline and json-timeline then could you just fix the color issue so that the progress bar text does not turn blue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants