Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change yaml-rust crate to serde-yaml or yaml-rust2 #461

Closed
itiB opened this issue Mar 24, 2022 · 4 comments · Fixed by #1464
Closed

Change yaml-rust crate to serde-yaml or yaml-rust2 #461

itiB opened this issue Mar 24, 2022 · 4 comments · Fixed by #1464
Assignees
@hitenkoku
Labels
enhancement New feature or request
Milestone
3.0 3rd Year Anni...

Comments

@itiB
Copy link
Collaborator

itiB commented Mar 24, 2022 •
edited by hitenkoku
Loading

Now Hayabusa using yaml-rust to read YAML files.
We want to change this crate to serde-yaml

  • Reason
    • yaml-rust can't write yaml file.
    • yaml-rust' latest update is a long time ago
@itiB itiB added the enhancement New feature or request label Mar 24, 2022
@itiB itiB self-assigned this Mar 24, 2022
@hitenkoku hitenkoku mentioned this issue Mar 30, 2022
Merged
3 tasks
@hitenkoku hitenkoku added this to the v1.3 milestone Mar 30, 2022
@itiB
Copy link
Collaborator Author

itiB commented Mar 30, 2022 •
edited
Loading

Serdeの宣言について
https://serde.rs/examples.html

@hitenkoku
Copy link
Collaborator

メモ: 構造体にする必要があり、修正コスト大

@hitenkoku hitenkoku modified the milestones: v1.3, v2.0 May 19, 2022
@hitenkoku hitenkoku assigned hitenkoku and unassigned itiB Jun 23, 2022
@YamatoSecurity YamatoSecurity changed the title Change yaml crate to serde-yaml Change yaml-rust crate to serde-yaml or yaml-rust2 Oct 14, 2024
@YamatoSecurity
Copy link
Collaborator

yaml-rust is lower-level so may provide petter performance and lower memory usage than serde. the serde crate is supposed to be easier to program with though.
I just noticed that there is a newer more maintained version of yaml-rust called yaml-rust2, so it might be better to upgrade to this than serde-yaml

https://crates.io/crates/yaml-rust2

@YamatoSecurity
Copy link
Collaborator

serde-yaml has been deprecated all of a sudden and it is recommended to upgrade to yaml-rust2

https://users.rust-lang.org/t/serde-yaml-deprecation-alternatives/108868/19

@YamatoSecurity YamatoSecurity mentioned this issue Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hitenkoku hitenkoku

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.0 3rd Year Anniversary Release
Development

Successfully merging a pull request may close this issue.

update to rust-yaml2 Yamato-Security/hayabusa
3 participants
@hitenkoku @itiB @YamatoSecurity