Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning rates do not match paper #4

Open
bsaund opened this issue Apr 15, 2018 · 1 comment
Open

Learning rates do not match paper #4

bsaund opened this issue Apr 15, 2018 · 1 comment

Comments

@bsaund
Copy link

bsaund commented Apr 15, 2018

Thanks for the work and for releasing the code! We hope to use this on our robot.
I also appreciate how well all of the learning parameters are documented.

In the paper, Section "3.4 Training" lists the following learning rates for the Adam optimizer:
discriminator: 0.0001
generator: 0.0005

The code provided uses:
discriminator: 0.00005
generator: 0.0001

Is this a typo (both switching dis and gen, and missing a '0')? Did you change the learning rates after writing the paper?

@Yang7879
Copy link
Owner

@bsaund Great thanks for reporting the mismatch. The learning rate in the release code is correct. We will update it in next paper version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants