Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert sgp and sgp_betaDiv` into a single function #2

Open
Yash-10 opened this issue Apr 8, 2023 · 0 comments
Open

Convert sgp and sgp_betaDiv` into a single function #2

Yash-10 opened this issue Apr 8, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@Yash-10
Copy link
Owner

Yash-10 commented Apr 8, 2023

Both have many repetitions and in fact, sgp is just a special case of sgp_betaDiv. It makes much more sense to use a single function called sgp_generalized and allow using both normal SGP (using KL divergence) and allowing any arbitrary beta value (using beta divergence).
@Yash-10 Yash-10 added the enhancement New feature or request label Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Yash-10