Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --exclude-lines from baseline, if there #151

Closed
KevinHock opened this issue Mar 26, 2019 · 1 comment
Closed

Use --exclude-lines from baseline, if there #151

KevinHock opened this issue Mar 26, 2019 · 1 comment
Labels
help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.

Comments

@KevinHock
Copy link
Collaborator

KevinHock commented Mar 26, 2019

We somewhat recently added an --exclude-lines option when scanning, that will end up in the baseline here:

  "exclude": {
    "files": "...",
    "lines": "(foo)"
  },

We might as well not make people do e.g.

    -   id: detect-secrets
        args: ['--baseline', '.secrets.baseline', '--exclude-lines', '(foo)']

in their .pre-commit-config.yaml, if they already have a line exclude in their baseline.

@KevinHock KevinHock added enhancement help wanted Indicates that we would like someone that’s not a maintainer to work on the issue. labels Mar 26, 2019
@domanchi
Copy link
Contributor

This is handled in the upcoming v1 release through filters (https://github.com/Yelp/detect-secrets/blob/pre-v1-launch/docs/filters.md). Once the baseline is loaded, all settings are also configured, which carry over any line/file exclusions, as well as other filters (e.g. wordlist, verifiability, etc.)

Closing as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Indicates that we would like someone that’s not a maintainer to work on the issue.
Projects
None yet
Development

No branches or pull requests

2 participants