Skip to content
This repository has been archived by the owner on Apr 18, 2018. It is now read-only.

Request bookmarklet only handles trac ticket numbers #88

Open
ymilki opened this issue Aug 18, 2014 · 1 comment
Open

Request bookmarklet only handles trac ticket numbers #88

ymilki opened this issue Aug 18, 2014 · 1 comment

Comments

@ymilki
Copy link
Member

ymilki commented Aug 18, 2014

In pushmanager/templates/create_request_bookmarklet.js, bug numbers from reviewboard are parsed as:

 var ticketNumberToURL = function(bug) {
        return 'https://' + Settings['trac']['servername'] + '/ticket/' + bug.match(/\d+/)[0];
    };

This should either be more general to handle multiple types of issue ids or point to a separate service that can redirect to the correct place. Internally, we have separate redirect service.

@michalczapko
Copy link
Contributor

This is already fixed: d7706df

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants