Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should generate the protobuf code with an old compiler #128

Open
drolando opened this issue May 1, 2019 · 1 comment
Open

We should generate the protobuf code with an old compiler #128

drolando opened this issue May 1, 2019 · 1 comment

Comments

@drolando
Copy link
Contributor

drolando commented May 1, 2019

When importing py_zipkin on a system with an older protobuf library version (doesn't need to be a different major version, minor versions are enough) we might get errors due to the code using newer features.

Installing py-zipkin 0.18.2 in a system with protobuf==3.5.2 causes TypeError: __init__() got an unexpected keyword argument 'serialized_options'.
From protocolbuffers/protobuf#4716:

This error happens when new generated code is being used with an old runtime, That's a configuration we don't support. Upgrade protobuf runtime to newer version later than your protoc version can solve the error.
For compatibility, we support older generated code with newer protobuf runtime.

We should probably regenerate the protobuf code with an older compiler. @adriancole what do you do in java-land? I'd guess you'll have the same issue.

@codefromthecrypt
Copy link

the only problem we had was caused by depending on a google type "empty" but that was reverted in api 2.1 which should be released soon. Can you try with the file from here? https://dist.apache.org/repos/dist/dev/incubator/zipkin/zipkin-api/0.2.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants