Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Route:query() #19

Open
YetAnotherClown opened this issue Jul 7, 2024 · 0 comments
Open

Rename Route:query() #19

YetAnotherClown opened this issue Jul 7, 2024 · 0 comments
Labels
reserved for version 1.0.0 This issue will not be resolved until development of version 1.0.0

Comments

@YetAnotherClown
Copy link
Owner

Thanks to Ukendio for the input regarding this issue!

The Route:query() method is misleading, the query keyword should be reserved for the ECS that YetAnotherNet is integrating with.

Suggested names for the method are:

  • Route:drain()
  • Route:read()

Other names may be suggested in the comments here.

The QueryResult object should also be renamed to reflect this. These changes are also reserved for version 1.0.0 to avoid introducing breaking changes for issues like this, and instead fix them all in the official 1.0.0 release.
@YetAnotherClown YetAnotherClown added the reserved for version 1.0.0 This issue will not be resolved until development of version 1.0.0 label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reserved for version 1.0.0 This issue will not be resolved until development of version 1.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YetAnotherClown