Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FluentBundle into several classes with IFluentBundle #49

Closed
Ygg01 opened this issue Jan 1, 2024 · 0 comments · Fixed by #50
Closed

Refactor FluentBundle into several classes with IFluentBundle #49

Ygg01 opened this issue Jan 1, 2024 · 0 comments · Fixed by #50

Comments

@Ygg01
Copy link
Owner

Ygg01 commented Jan 1, 2024

Idea: to avoid ContainsKeys() and enable extra bundle types. Using TryAdd on IDictionary is not considered safe.

Implementation:

  1. Extract common FluentBundle operations to IFluentBundle interface.
  2. Add optional net8.0 support.
  3. Add three implementations - ConcurrentBundle, NonConcurrentBundle and FrozenBundle.

NOTE: This is a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make FluentBundle abstract and do some API refactoring Ygg01/Linguini
1 participant
@Ygg01