Fix the error if buffer list empty #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yggdroot
reviewed
May 15, 2018
| self._max_bufname_len = max((int(lfEval("strdisplaywidth('%s')" | ||
| % escQuote(getBasename(buffers[nr].name)))) | ||
| for nr in mru.getMruBufnrs() if nr in buffers), | ||
| default=0) |
There was a problem hiding this comment.
Thanks in advance. But max() does not have "default" argument in python2 and python3 that version is less than 3.4.
There was a problem hiding this comment.
Perhaps the fix can be like this:
self._max_bufname_len = max([int(lfEval("strdisplaywidth('%s')"
% escQuote(getBasename(buffers[nr].name))))
for nr in mru.getMruBufnrs() if nr in buffers] or [0])
Yggdroot
added a commit
that referenced
this pull request
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue that the plugin will raise an exception if there is no buffers in the buffer list.
It can be shown by opening Vim, opening a help doc, setting the help window as the only window and then calling LeaderfBuffer.