Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about CARE-Weight Relation weight normalization #5

Closed
SongRb opened this issue Oct 29, 2020 · 1 comment
Closed

Question about CARE-Weight Relation weight normalization #5

SongRb opened this issue Oct 29, 2020 · 1 comment

Comments

@SongRb
Copy link

SongRb commented Oct 29, 2020

It seems that the softmax function is applied in embed_size dimension, not the relation dimension.

w = F.softmax(alpha, dim=0)

@YingtongDou
Copy link
Owner

Hi,

Thanks for finding this issue! I will update the code later.

With the new softmax, the CARE-weight will have better performance, and the relation weight values are more reasonable.

If you find any other interesting issues, please feel free to point it out. I appreciate it a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants