Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoast SEO 8.0 does not work in IE11 #10539

Closed
dariaknl opened this issue Aug 6, 2018 · 4 comments
Closed

Yoast SEO 8.0 does not work in IE11 #10539

dariaknl opened this issue Aug 6, 2018 · 4 comments
Assignees
Labels
component: gutenberg regression Label for high-prio issue
Milestone

Comments

@dariaknl
Copy link
Contributor

dariaknl commented Aug 6, 2018

How can we reproduce this behavior?

  1. In IE11 activate Gutenberg
  2. In IE11 activate Yoast SEO free 8.0 RC1

Check post in Classic Editor:
image 4

Check post in Gutenberg:
image 3
Error:

> Invariant Violation: Minified React error #143; visit https://reactjs.org/docs/error-decoder.html?invariant=143 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
>   at r (http://localhost/wordpress/wp-content/plugins/wordpress-seo/js/dist/commons-80-RC1.min.js?ver=8.0-RC1:6:14478)
>   at r (http://localhost/wordpress/wp-content/plugins/wordpress-seo/js/dist/commons-80-RC1.min.js?ver=8.0-RC1:6:42864)
>   at U.Children.only (http://localhost/wordpress/wp-content/plugins/wordpress-seo/js/dist/commons-80-RC1.min.js?ver=8.0-RC1:14:1464)
>   at n.prototype.render (http://localhost/wordpress/wp-content/plugins/wordpress-seo/js/dist/wp-seo-post-scraper-80-RC1.min.js?ver=8.0-RC1:59:72656)
>   at Xf (http://localhost/wordpress/wp-content/plugins/gutenberg/vendor/react-dom.min.82e21c65.js:91:253)
>   at yh (http://localhost/wordpress/wp-content/plugins/gutenberg/vendor/react-dom.min.82e21c65.js:102:310)
>   at lg (http://localhost/wordpress/wp-content/plugins/gutenberg/vendor/react-dom.min.82e21c65.js:120:82)
>   at mg (http://localhost/wordpress/wp-content/plugins/gutenberg/vendor/react-dom.min.82e21c65.js:120:384)
>   at gc (http://localhost/wordpress/wp-content/plugins/gutenberg/vendor/react-dom.min.82e21c65.js:127:200)
>   at vb (http://localhost/wordpress/wp-content/plugins/gutenberg/vendor/react-dom.min.82e21c65.js:126:230)

Technical info

  • WordPress version: 4.9.8
  • Yoast SEO version: 8.0 RC1
@dariaknl dariaknl added the regression Label for high-prio issue label Aug 6, 2018
@moorscode
Copy link
Contributor

I think the easiest way to test this and have output that you can use: build the project locally with grunt build:js and copy the folder onto an USB drive (or use some online service) to transfer it onto the Windows laptop Daria has for testing purposes.

@afercia
Copy link
Contributor

afercia commented Aug 6, 2018

Building release/8.0 on Windows and using IE11 shows these errors:

screenshot 43

SCRIPT5022: Objects are not valid as a React child (found: object with keys {$$typeof, type, key, ref, props, _owner, _store}). If you meant to render a collection of children, use an array instead.

The above error occurred in the <Connect(Metabox)> component:
    in Connect(Metabox) (created by MetaboxPortal)
    in MetaboxPortal
    in t
...

@afercia
Copy link
Contributor

afercia commented Aug 6, 2018

In the Gutenberg page there's one more error:

SCRIPT5022: React.Children.only expected to receive a single React element child.
post.php (49,5)

of course, being IE11, line 49 in post.php seems to be completely not relevant.

@Dieterrr Dieterrr added development and removed queue labels Aug 6, 2018
@Dieterrr Dieterrr self-assigned this Aug 6, 2018
@Dieterrr Dieterrr added queue and removed development labels Aug 6, 2018
@Dieterrr Dieterrr removed their assignment Aug 6, 2018
@afercia afercia self-assigned this Aug 7, 2018
@afercia afercia added development and removed queue labels Aug 7, 2018
@afercia
Copy link
Contributor

afercia commented Aug 7, 2018

OK so first thing: building on Windows I was getting this error:

mingw64__c_projects_wp_plugins_wordpress-seo 8_5_2018 1_47_59 pm

and yarn add babel-preset-stage-0 fixed it. This was unrelated though. Inspired by this comment: facebook/react#8379 (comment) I've seen in paths.js babel-polyfill is last:

"babel-polyfill",

Moving it as first thing in the vendor array fixes it for me. Metabox rendered in IE 11 with no errors. I'd strongly recommend to double check and test also on another Windows machine with IE 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: gutenberg regression Label for high-prio issue
Projects
None yet
Development

No branches or pull requests

6 participants