Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we import React in our Gutenberg blocks: #11413

Closed
afercia opened this issue Oct 25, 2018 · 1 comment · Fixed by #11926
Closed

Should we import React in our Gutenberg blocks: #11413

afercia opened this issue Oct 25, 2018 · 1 comment · Fixed by #11926

Comments

@afercia
Copy link
Contributor

afercia commented Oct 25, 2018

Right now, the FAQ block imports React:

/* External dependencies */
import React from "react";
import { __ } from "@wordpress/i18n";

while the How-to block doesn't:

/* External dependencies */
import { __ } from "@wordpress/i18n";
/* Internal dependencies */

@afercia
Copy link
Contributor Author

afercia commented Dec 12, 2018

Asked live @xyfi and no, we shouldn't import React 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants