Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n textdomains; specifically in our JavaScript packages #13360

Closed
igorschoester opened this issue Aug 7, 2019 · 1 comment
Closed

i18n textdomains; specifically in our JavaScript packages #13360

igorschoester opened this issue Aug 7, 2019 · 1 comment

Comments

@igorschoester
Copy link
Member

Via the following PR I found out we forgot the translations when moving code to their own packages: #13359

That solution could be improved still. 2 things come to mind:

  1. The textdomain used in the JavaScript packages are still yoast-components. Should this be changed to the package name?
  2. For every package:
    1. An entry is added in the package.json scripts.
    2. A Grunt shell task is created (which runs the script above).
    3. A Grunt copy task is created (which moves the output of above).
    4. The above tasks are added to the Grunt build:i18n:potFiles alias list.
@igorschoester
Copy link
Member Author

Closing this in favor of a comment in the readme of the javascript repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant