Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoast is blocking post editor from getting iFramed #20535

Open
8 of 11 tasks
fabiankaegy opened this issue Jul 28, 2023 · 3 comments
Open
8 of 11 tasks

Yoast is blocking post editor from getting iFramed #20535

fabiankaegy opened this issue Jul 28, 2023 · 3 comments

Comments

@fabiankaegy
Copy link

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

As of WordPress 6.3, the post editor is finally also getting rendered in an iFrame for non block-based themes if all registered blocks support apiVersion 3 and there are no classic metaboxes registered. (See the Dev Note)

Sadly Yoast still uses this method for integrating into the edit post screen and is therefore blocking us from finally being able to use the iframed post editor.

To Reproduce

Step-by-step reproduction instructions

  1. Install a clean WordPress 6.3 environment
  2. Activate a traditional or hybrid theme (such as twentytwenty)
  3. Open the post editor
  4. See that it is rendered inside an iframe
  5. Activate the Yoast SEO plugin
  6. Open the post editor
  7. See that it isn't rendered in an iframe

Expected results

  1. Even with Yoast SEO enabled, the post editor should be able to render in an iframe

Actual results

  1. The post editor is blocked from rendering in an iframe when Yoast SEO is active

Screenshots, screen recording, code snippet

If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.

The code in core controlling whether the editor gets loaded in an iframe is located here: https://github.com/WordPress/gutenberg/blob/trunk/packages/edit-post/src/components/visual-editor/index.js#L357C7-L364C8 As you can see, it checks whether there are any traditional metaboxes rendered in the editor and if so bails out.

Technical info

  • If relevant, which editor is affected (or editors):
  • Block Editor
  • Gutenberg Editor
  • Elementor Editor
  • Classic Editor
  • Other:
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other:

Used versions

  • Device you are using: MacBook Pro
  • Operating system: macOS 13.4.1
  • PHP version: 8.1
  • WordPress version: 6.3 (RC2)
  • WordPress Theme: twentytwenty
  • Yoast SEO version: 20.11
@fabiankaegy
Copy link
Author

I'd also like to point out that this issue has been present in previous WordPress versions also. Just only for block-based themes such as twentytwentyone, twentytwentytwo, and twentytwentythree

@tcmulder
Copy link

Experiencing this issue as well. Are there plans to solve this?

@stokesman
Copy link

This issue is soon to be outdated per the Make post Roadmap to 6.7. The editor iframe will be used even with classic meta boxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants