Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(PinCode_Widget): introduce PinCode Trait Widget #54

Merged
merged 39 commits into from
Sep 27, 2022

Conversation

ses110
Copy link
Contributor

@ses110 ses110 commented Aug 30, 2022

This should cover DX-451 (List PIN Codes) and DX-467 (Create new PIN Code)

Pre-requisite: Pending a new release of yonomi-sdk-dart

Pin Code List View

Pin Code List

Pin Code Detail View (creating pin code only)

Pin Code Detail

@ses110 ses110 marked this pull request as ready for review September 15, 2022 00:14
@ses110 ses110 requested a review from a team as a code owner September 15, 2022 00:14
@ses110 ses110 requested review from grizzly-atoms, rlperez and JohnCrafton and removed request for a team September 15, 2022 00:14
lib/ui/color_constants.dart Show resolved Hide resolved
lib/ui/widget_style_constants.dart Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 98.68% // Head: 99.21% // Increases project coverage by +0.52% 🎉

Coverage data is based on head (6f7fd25) compared to base (010f30d).
Patch coverage: 98.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   98.68%   99.21%   +0.52%     
==========================================
  Files          45       48       +3     
  Lines        1373     1528     +155     
==========================================
+ Hits         1355     1516     +161     
+ Misses         18       12       -6     
Impacted Files Coverage Δ
lib/traits/detail_screen.dart 100.00% <ø> (+21.05%) ⬆️
lib/ui/widget_style_constants.dart 100.00% <ø> (ø)
lib/traits/slim/pin_code_slim_widget.dart 98.26% <98.26%> (ø)
lib/assets/traits/device_item_icon.dart 100.00% <100.00%> (ø)
lib/assets/traits/pin_code_icon.dart 100.00% <100.00%> (ø)
lib/providers/pin_code_provider.dart 100.00% <100.00%> (ø)
lib/traits/device_widget_factory.dart 100.00% <100.00%> (ø)
lib/traits/pin_code_widget.dart 100.00% <100.00%> (ø)
lib/traits/slim/brightness_slim_widget.dart 100.00% <100.00%> (ø)
lib/providers/widget_state.dart
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ses110 ses110 merged commit 9eaf083 into main Sep 27, 2022
@ses110 ses110 deleted the feat/pin_code_widget branch September 27, 2022 21:59
yonomi-developer pushed a commit that referenced this pull request Sep 27, 2022
# [2.11.0](v2.10.2...v2.11.0) (2022-09-27)

### Features

* **PinCode_Widget:** introduce PinCode Trait Widget ([#54](#54)) ([9eaf083](9eaf083))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants