Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide sensitive config from logs #399

Open
tooptoop4 opened this issue Dec 8, 2020 · 2 comments
Open

hide sensitive config from logs #399

tooptoop4 opened this issue Dec 8, 2020 · 2 comments
Labels
good first issue help wanted

Comments

@tooptoop4
Copy link

If i have an input yaml connecting to jdbc source like:

inputs:
  somedb:
    jdbc:
      connectionUrl: jdbc:jtds:redact
      user: someuser
      password: somepass

the log has

2020-12-08 17:01:28,076 [main] INFO  com.yotpo.metorikku.Job - these are the config inputs: Some(Map(.....somepass

ideally this should be printed as ****** in the log
@amirhalatzi
Copy link
Contributor

You're absolutely right. You're most welcomed to send a PR with relevant changes to the Log4J setup. There's plenty of tutorials online on how to achieve this.

@sidharthbolar
Copy link

Hi Is this issue still open for PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amirhalatzi @sidharthbolar @tooptoop4