You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Naming: We have many create_* functions that create R6 objects like the Experiment, DGP, and Method classes. On the other hand, we used init_docs() for setting up the Rmd documentation directory structure. I think renaming create_sim() to init_sim() would improve our API consistency. Another point of confusion is the hpc argument, which could mislead users into thinking that with hpc = TRUE their simulation will automatically work in a distributed computing environment (e.g., a Slurm cluster). I think we should rename this argument somehow to make it a bit more clear. Maybe scripts_dir (and also rename tests to tests_dir / add a logs_dir arg)? Another option (my preference) is to replace the hpc and tests args with an init_dirs argument that accepts string vectors, default c("logs", "scripts", "tests").
Functionality: Can we have create_sim() optionally call init_docs() ? E.g., we could add a boolean argument init_docs.
Maybe create_sim() and init_docs() should be combined, somehow?
The text was updated successfully, but these errors were encountered:
Naming: We have many create_* functions that create R6 objects like the Experiment, DGP, and Method classes. On the other hand, we used init_docs() for setting up the Rmd documentation directory structure. I think renaming create_sim() to init_sim() would improve our API consistency.
I like the idea of renaming create_sim() to init_sim().
Another point of confusion is the hpc argument, which could mislead users into thinking that with hpc = TRUE their simulation will automatically work in a distributed computing environment (e.g., a Slurm cluster). I think we should rename this argument somehow to make it a bit more clear. Maybe scripts_dir (and also rename tests to tests_dir / add a logs_dir arg)? Another option (my preference) is to replace the hpc and tests args with an init_dirs argument that accepts string vectors, default c("logs", "scripts", "tests").
Good points. Adding the described init_dirs sounds good to me.
Functionality: Can we have create_sim() optionally call init_docs() ? E.g., we could add a boolean argument init_docs.
Maybe create_sim() and init_docs() should be combined, somehow?
I'm not sure if this is very natural. Currently, init_docs initializes the documentation for a simulation experiment created with create_experiment(). I think create_sim() initializes the directory structure for the overarching "project" or "study", which may consist of multiple simulation experiments. In some sense, maybe we should consider renaming create_sim() to init_sim_study() or init_study() or something of the like.
create_*
functions that createR6
objects like theExperiment
,DGP
, andMethod
classes. On the other hand, we usedinit_docs()
for setting up the Rmd documentation directory structure. I think renamingcreate_sim()
toinit_sim()
would improve our API consistency. Another point of confusion is thehpc
argument, which could mislead users into thinking that withhpc = TRUE
their simulation will automatically work in a distributed computing environment (e.g., a Slurm cluster). I think we should rename this argument somehow to make it a bit more clear. Maybescripts_dir
(and also renametests
totests_dir
/ add alogs_dir
arg)? Another option (my preference) is to replace thehpc
andtests
args with aninit_dirs
argument that accepts string vectors, defaultc("logs", "scripts", "tests")
.create_sim()
optionally callinit_docs()
? E.g., we could add a boolean argumentinit_docs
.Maybe
create_sim()
andinit_docs()
should be combined, somehow?The text was updated successfully, but these errors were encountered: