Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The preview Icon could be specific to the type of file (at the moment its just a paperclip) #149

Closed
max-carroll opened this issue Apr 30, 2020 · 2 comments · Fixed by #154 or #155
Closed
Assignees
Milestone

Comments

@max-carroll
Copy link
Contributor

We could perhaps have default icons for types of files such as documents, video, text etc... but then also provide the developer with the ability to supply their own,

So in the Preview List we could have more bespoke logic for selecting an image based on file type,

We could also have some props like this if we want to override them
fileIcons= {
document:

,
default: ,
video:
}

@max-carroll max-carroll changed the title The preview Icon should be specific to the type of file (at the moment its just a paperclip) The preview Icon could be specific to the type of file (at the moment its just a paperclip) Apr 30, 2020
@max-carroll
Copy link
Contributor Author

This is actually important for some development I'm doing for my own product, if you like I can start on it right away 😀

@max-carroll
Copy link
Contributor Author

Ok, so I started work on this already, I pulled the image out into its own component, what do you think of this approach?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment