Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be using Typography instead of <p></p> #31

Closed
PolGuixe opened this issue Feb 19, 2019 · 2 comments
Closed

Should be using Typography instead of <p></p> #31

PolGuixe opened this issue Feb 19, 2019 · 2 comments

Comments

@PolGuixe
Copy link

As the library already uses Material-UI I would make use of the <Typography/> component for texts to make sure it works well with the current's app theme.
@IsabellaRey
Copy link

This includes the text for displaying the filename

@panz3r panz3r mentioned this issue Mar 26, 2020
Merged
@panz3r
Copy link
Contributor

panz3r commented Apr 16, 2020

Hi @PolGuixe and @IsabellaRey ,

Suggested changes are already on master (see PR #121 ) and will be on v2.x (see PR #132 ).

Closing this issue for now, let me know if you find any other problem related to this issue.

@panz3r panz3r closed this as completed Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@panz3r @PolGuixe @IsabellaRey