RFC: ZF-Commons Practices & Roles

[EvanDotPro]

Comments and discussion for: RFC: ZF-Commons Practices & Roles

[Thinkscape]

Updated the RFC with "50% + 1" voting logic (because implicit floor/ceil is never good in edge cases) and added one more rule for reviewing PRs. Take a look ...

[EvanDotPro]

@Thinkscape Looks good!

[b-durand]

Add a section about versioning. ZfCModules should follow the schema of ZF2:

• 1.0.0-dev1
• 1.0.0-beta1
• 1.0.0-rc1
• 1.0.0

And, we must add tag (on git).

A version 0.0.1 has no meaning at the semantic level. The first first should start at 0.1.0, because we can't patch a non-existant version (e.g. "v0.0").

This allows us to develop a tool to generate a changelog for each module. This can be a tool to generate a static page to host on GitHub Pages. The benefit is to show users the major improvements and fixes for each version (sample on composer).

[EvanDotPro]

@b-durand +1

[weierophinney]

@b-durand +1

[weierophinney]

I'd argue under the "Commit Practices" section, we should adopt git-flow as the standard workflow. This would be in line with the ZF2 repository, and promote consistency in the workflow.

[b-durand]

At this time, we can adopt PSR-2 with Travis CI like ZF-Commons/ZfcUser#152.