Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres Upsert - Unique Field Support #114

Open
valeeum opened this issue Dec 13, 2020 · 0 comments
Open

Postgres Upsert - Unique Field Support #114

valeeum opened this issue Dec 13, 2020 · 0 comments

Comments

@valeeum
Copy link
Contributor

valeeum commented Dec 13, 2020

Currently, postgres upsert only takes primary keys into consideration for generating ON CONFLICT statements. It would be helpful to also be able to upsert against unique fields. One solution would be to be able to pass in 'pkeys' via options.

Current code:
if (this.upsert) this.pkeys = this.getPrimaryKeys();

Suggested Change:
if (this.upsert) this.pkeys = this.options.pkeys ? Promise.resolve(this.options.pkeys) : this.getPrimaryKeys();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant