Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jubjub keys #3

Closed
3 tasks done
alv-around opened this issue Mar 7, 2023 · 3 comments · Fixed by #2
Closed
3 tasks done

Add jubjub keys #3

alv-around opened this issue Mar 7, 2023 · 3 comments · Fixed by #2
Assignees

Comments

@alv-around
Copy link

alv-around commented Mar 7, 2023

This ticket is an extension of ZK-Plus/ZoKrates#1.
In order to proper test the implementation of the jubjub signatures in ZoKrates, you first to generate valid signatures in the first place. Currently there no maintained libraries that support the key generation of the jubjub curve. Reason for pycrypto to support it.

Pycrypto:

  • Generate JubJub keys
  • Write tests
  • Modify Point and FQ interfaces to use multiple Edwards Curves
@alv-around alv-around self-assigned this Mar 7, 2023
@alv-around alv-around linked a pull request Mar 7, 2023 that will close this issue
@alv-around
Copy link
Author

@JonathanHeiss I finished this ticket last week, but I am not sure how to proceed with the review. Originally, I though to create a PR to against Zokrate's Pycrypto and have them review it. But last week we discussed, that we would like to use this features as way to position Zokrates+, so for the moment I just create the PR against our main and added you as reviewer. Let me know if I should do otherwise.

@alv-around
Copy link
Author

@nikiblume can you take over the review of this ticket?

@alv-around alv-around assigned nikiblume and unassigned alv-around May 17, 2023
@nikiblume
Copy link

@alvaro-alonso yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants