Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle for volume rocker sound #17

Closed
switchblade34 opened this issue Jun 24, 2024 · 5 comments
Closed

Toggle for volume rocker sound #17

switchblade34 opened this issue Jun 24, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@switchblade34
Copy link

Describe the problem

I don't need the key sound for when I increase/decrease my volume as I don't really have a rocker on my keyboard.

Describe the solution you'd like

A simple toggle to turn on/off the key sound when changing the volume should be enough.

Alternatives considered

No response

Additional context

No response

@switchblade34 switchblade34 added the enhancement New feature or request label Jun 24, 2024
@ZacharyL2
Copy link
Owner

Thank you for your suggestion, I almost forgot about it. Actually, the backend already supports volume control.

I will include this feature in the next version, so stay tuned.

@ZacharyL2
Copy link
Owner

@switchblade34 I've just released 0.0.4, now you should be able to adjust the volume of KeyEcho.

@switchblade34
Copy link
Author

Hey, thanks for adding volume control but this is not what I was talking about in the feature request. Maybe I didn't explain it the right way as English isn't my first language so I'll explain it in more detail:

My keyboard has a scroll wheel that changes the volume on my laptop. Whenever I change the system volume using the scroll wheel, KeyEcho makes a sound each time the volume is changed. This sound is different to that of the usual keypress sound. It's a special sound (it was a special sound in v0.0.3 but now that I have updated to v0.0.4 that sound is just like a normal keypress sound) like how enter & space keys have their own unique sound. Since my scroll wheel is smooth, I don't really want a sound which I change the system volume. So I was wondering whether it would be possible to add a toggle that lets the user choose whether they want a KeyEcho response whenever they change the system volume.

I hope this makes it clear. Thank you.

@ZacharyL2 ZacharyL2 reopened this Jun 27, 2024
@ZacharyL2
Copy link
Owner

I'm sorry for the misunderstanding earlier.

I now understand your point clearly. Actually, KeyEcho doesn't produce sound feedback when users adjust the system volume.

The issue you encountered stems from this line of code. It defaults to emitting the sound of pressing the "A" key if there's no corresponding keyboard mapping.

I'll fix this in an upcoming update. Thanks again for your feedback.

@ZacharyL2
Copy link
Owner

I fixed it in v0.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants