Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: Extract Maker to Studio, change implementation to be fully on-chain and no reliance on third party APIs #357

Merged
merged 1 commit into from
May 4, 2022
Merged

feat: Extract Maker to Studio, change implementation to be fully on-chain and no reliance on third party APIs #357

merged 1 commit into from
May 4, 2022

Conversation

immasandwich
Copy link
Contributor

Description

  • Current implementation in Zapper API of Maker relies on DeFiExplore API
  • This PR rewrites the implementation to fully pull contract positions and balances from on-chain requests
  • Also, dynamically retrieves all of the registered ilks so we don't need to maintain a manual list anymore

Checklist

How to test?

http://localhost:5001/apps/maker/balances?addresses[]=0x0a6d97444602b96f7e231e9dd5ecec9251a9cafe

@immasandwich immasandwich merged commit 01f0052 into main May 4, 2022
@immasandwich immasandwich deleted the extract-and-refactor-maker branch May 4, 2022 18:30
@zapper-bot zapper-bot mentioned this pull request May 4, 2022
Merged
@zapper-bot zapper-bot mentioned this pull request Jun 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@immasandwich