This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat: Integration for Gro Protocol #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 29, 2022 16:45
Note: Vesting position still needs to be added and balance fetcher
0xfarhaan
changed the title
immasandwich
reviewed
May 6, 2022
Note price per share calculation denormalised as well.
immasandwich
reviewed
May 6, 2022
This shows the underlying token image and correct label.
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
Note vesting contract address: 0x748218256AfE0A19a88EBEB2E0C5Ce86d2178360 I'm not sure how to correctly reuturn the balances as the endpoint errors out with this feature.
immasandwich
reviewed
May 6, 2022
src/apps/gro/avalanche/gro.vesting.contract-position-fetcher.ts
Outdated
Show resolved
Hide resolved
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
|
Example of an address that should have vesting position balances returned 0x6523f418c4b7260b070a17c47a206b66935d67cd |
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
immasandwich
reviewed
May 6, 2022
Changes: - lowercase addresses - return correct label - use correct token wrappers i.e. locked and claimable
Changes: - Remove unused files - Change pools definition to farm for masterchief - correct the price for labs token fetcher
immasandwich
reviewed
May 8, 2022
Merged
1 task
|
Hello @0xfarhaan ! Looks like you did not provide an address when submitting your PR. I recognize it may have seemed kind of random that we were asking for a wallet address with a PR submission, but we are actually looking for ways to reward Studio contributors in the future. Is there an address you’d want to provide? Could even be an empty address, if you do not have an doxxed address Let me know! Also, if you’d like to privately provide it, feel free to shoot me a TG https://t.me/SamIAm_0x or DM on the Zapper Discord. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Gro Protocol under Apps:
Checklist
How to test?
address to test ETH pool balances: 0xbd722F41bca276B05a27E0B716bdeC2cB801D952
address to test AVAX Labs balances: 0x9b4A2a6D9c244c8c94e31A84A169E23b4b7E5b1f