Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: add across protocol #395

Merged
merged 11 commits into from
May 20, 2022
Merged

feat: add across protocol #395

merged 11 commits into from
May 20, 2022

Conversation

liuyepiaoxiang
Copy link
Contributor

@liuyepiaoxiang liuyepiaoxiang commented May 8, 2022 •
edited
Loading

Description

Checklist

How to test?

@immasandwich
Copy link
Contributor

Hello sir! Happy to see your contribution! Feel free to swing by the Discord in the #build-on-zapper channel for any questions, we'll be glad to support!

@liuyepiaoxiang
Copy link
Contributor Author

lious.eth

@immasandwich
Copy link
Contributor

immasandwich commented May 9, 2022 •
edited
Loading

  1. The address returned by the l1Token call is in checksum format (i.e.: with capital letters), lowercase it before you try to match on baseTokens
  2. In your for loop on lines 53-56, you're not using value. Use total += value instead of total += total

immasandwich
immasandwich reviewed May 20, 2022
View reviewed changes
Copy link
Contributor

@immasandwich immasandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay ser! Reviewing now!

@immasandwich immasandwich merged commit 1b55ec8 into Zapper-fi:main May 20, 2022
@zapper-bot zapper-bot mentioned this pull request May 20, 2022
Merged
@zapper-bot zapper-bot mentioned this pull request Jun 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@immasandwich immasandwich immasandwich left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuyepiaoxiang @immasandwich