This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix(solace): Adjust Solace implementation #472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Solace team to review:
.png
range
method fromlodash
rather than declaring your ownfindTokens
, we were "building" the app specific token. Instead, you can usethis.appToolkit.getAppTokenPositions
to get the tokens from another existing group, like so:findTokens
helper entirely.!
on the results ofbaseTokens.find
.Checklist
How to test?