Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(coslend): add coslend app integration #586

Merged
merged 1 commit into from
Jun 8, 2022
Merged

feat(coslend): add coslend app integration #586

merged 1 commit into from
Jun 8, 2022

Conversation

coslendteam
Copy link
Contributor

@coslendteam coslendteam commented Jun 7, 2022

Description

add coslend app integration

  • supply (token) fetcher and cache manager
  • borrow contract position fetcher
  • balance fetcher
  • TVL fetcher

Checklist

How to test?

  1. edit/create .env adding ENABLED_APPS="coslend"
  2. run pnpm dev to spin up nest server
  3. visit dev endpoints below to see result of fetchers to integrate coslend:

@immasandwich
Copy link
Contributor

immasandwich commented Jun 7, 2022

Hello @coslendteam ! Integration looks great. I would suggest that you use import the CompoundAppModule as an in the imports array of the module, and use the helpers directly from the Compound app directory, rather than copying over the helpers. This would drop the amount of copy-pasta.

I see that there's some differences between the compound.supply.token-helper.ts and coslend.supply.token-helper.ts, but you can definitely adjust the compound.supply.token-helper.ts to include an oracle parameter optionally for resolving tokens that are not found in Zapper's base tokens.

Does that make sense? Feel free to swing by Discord for a quicker discussion pace.

@coslendteam
Copy link
Contributor Author

Hello @coslendteam ! Integration looks great. I would suggest that you use import the CompoundAppModule as an in the imports array of the module, and use the helpers directly from the Compound app directory, rather than copying over the helpers. This would drop the amount of copy-pasta.

I see that there's some differences between the compound.supply.token-helper.ts and coslend.supply.token-helper.ts, but you can definitely adjust the compound.supply.token-helper.ts to include an oracle parameter optionally for resolving tokens that are not found in Zapper's base tokens.

Does that make sense? Feel free to swing by Discord for a quicker discussion pace.

Our APY calculation is different, it is based on second, not block, the ABI has also changed, further, we may add more difference to update our app, so we suggest don't use compound helper directly.

@immasandwich immasandwich merged commit 96f70a3 into Zapper-fi:main Jun 8, 2022
@SamIam-0x
Copy link
Contributor

Hello @coslendteam !

Looks like you did not provide an address when submitting your PR. I recognize it may have seemed kind of random that we were asking for a wallet address with a PR submission, but we are actually looking for ways to reward Studio contributors in the future.

Is there an address you’d want to provide? Could even be an empty address, if you do not have an doxxed address

Let me know! Also, if you’d like to privately provide it, feel free to shoot me a TG https://t.me/SamIAm_0x or DM on the Zapper Discord.

Thanks!
Sam

@SamIam-0x
Copy link
Contributor

Gentle ping on the above @coslendteam !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants