-
Notifications
You must be signed in to change notification settings - Fork 381
feat(qi-dao): add gnosis chain support #686
Conversation
@@ -37,7 +37,7 @@ export class QiDaoVaultPositionHelper { | |||
constructor( | |||
@Inject(APP_TOOLKIT) private readonly appToolkit: IAppToolkit, | |||
@Inject(QiDaoContractFactory) protected readonly contractFactory: QiDaoContractFactory, | |||
) {} | |||
) { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix linting errors 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it was VSCode which auto-formatted on save, and VSC will follow ESLint. For example, adding multiple spaces between the {}
s will be turned into { }
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run the linter with pnpm run lint:fix
to resolve all linting problems.
Or, you can install the Prettier and ESLint VSCode extensions, and those should pick up the project configs, and format properly on save.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running pnpm run lint:fix
created the following patchfile: https://gist.github.com/the-emerald/096572bd8d10824be36aede65fa9f26e
with the error:
/home/emerald/zapper-studio/src/apps/bastion-protocol/helper/bastion-protocol.supply.token-helper.ts
27:37 error 'T' is defined but never used @typescript-eslint/no-unused-vars
27:69 error 'V' is defined but never used @typescript-eslint/no-unused-vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relevant files have been fixed in d9d6da3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly good, just two small comments to lowercase addresses and fix your linting errors.
Oh, and this PR won't work until CoinGecko adds MAI token address on the other chains. The Qi DAO team are aware of this and they've reached out to CG already as of yesterday. |
Description
Checklist
How to test?
Note:
/v2/prices
does not return the price of MAI on Gnosis Chain yet (address is0x3F56e0c36d275367b8C502090EDF38289b3dEa0d
).This is a straightforward copy-paste of existing code, it should work as is!