Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(qi-dao): add gnosis chain support #686

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

the-emerald
Copy link
Contributor

Description

  • Add support for Gnosis Chain for Qi DAO (mai.finance)

Checklist

How to test?

Note: /v2/prices does not return the price of MAI on Gnosis Chain yet (address is 0x3F56e0c36d275367b8C502090EDF38289b3dEa0d).

This is a straightforward copy-paste of existing code, it should work as is!

@@ -37,7 +37,7 @@ export class QiDaoVaultPositionHelper {
constructor(
@Inject(APP_TOOLKIT) private readonly appToolkit: IAppToolkit,
@Inject(QiDaoContractFactory) protected readonly contractFactory: QiDaoContractFactory,
) {}
) { }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix linting errors 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it was VSCode which auto-formatted on save, and VSC will follow ESLint. For example, adding multiple spaces between the {}s will be turned into { }.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can run the linter with pnpm run lint:fix to resolve all linting problems.

Or, you can install the Prettier and ESLint VSCode extensions, and those should pick up the project configs, and format properly on save.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running pnpm run lint:fix created the following patchfile: https://gist.github.com/the-emerald/096572bd8d10824be36aede65fa9f26e

with the error:

/home/emerald/zapper-studio/src/apps/bastion-protocol/helper/bastion-protocol.supply.token-helper.ts
  27:37  error  'T' is defined but never used  @typescript-eslint/no-unused-vars
  27:69  error  'V' is defined but never used  @typescript-eslint/no-unused-vars

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant files have been fixed in d9d6da3

Copy link
Contributor

@immasandwich immasandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just two small comments to lowercase addresses and fix your linting errors.

@the-emerald
Copy link
Contributor Author

Oh, and this PR won't work until CoinGecko adds MAI token address on the other chains. The Qi DAO team are aware of this and they've reached out to CG already as of yesterday.

@immasandwich immasandwich merged commit ee1d35b into Zapper-fi:main Jun 21, 2022
This was referenced Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants