Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

fix(umami): Fix name/pps, add TVL/APR/APY #700

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

Clonescody
Copy link
Contributor

Description

Updated the application name for better display
Fixed the pricePerShare decimals

Calling the UMAMI API to fetch following datas :

  • Marinating UMAMI TVL + APR
  • Compounding UMAMI TVL + APY

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is: 0xa03c3fc823457F95ffc3cc7fD5a5133d5AFb850A
  • (optional) As a contributor, my Twitter handle is: Clonescody

How to test?

Display fixes only

Copy link
Contributor

@immasandwich immasandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, specifically please cache the API requests as mentioned. Once you're good to go, ping me and we can merge.

@Clonescody
Copy link
Contributor Author

@immasandwich Resolved everything 👌

When we're done I'll probably check to contribute to the docs as well, few things that could be added to make it even easier :)

@Clonescody Clonescody requested a review from immasandwich June 21, 2022 23:16
@immasandwich immasandwich merged commit 22bfc87 into Zapper-fi:main Jun 22, 2022
This was referenced Jun 22, 2022
@Clonescody Clonescody deleted the fix/umami-name-apr branch January 21, 2024 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants