Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: add integration with SINGLE LYF positions #738

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

singlefinance
Copy link
Contributor

Description

  • add integration with SINGLE LYF positions
  • Please note that: this is our second PR, which is a superset of our first PR feat: add integration with SINGLE lending vaults #727, please feel free to accept them in order (after successful review(s)), it is also perfectly fine to just accept this second PR since it includes both sets of changes.

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

Addresses of user with active positions (at the time of writing):
0x885a8Bd0AED00e5a042E7BB788fa56c9e0fee5a4
0x8CE4c74Ce823e79Ad2d71498ba5697Bb57EBCd7f
0x3326822e4CAC8ADA1c00F2B44d7e5822a010b2b4

@immasandwich
Copy link
Contributor

Hello @singlefinance ! First PR is merged, please resolve conflicts and we can get this one in next 🙏

@immasandwich immasandwich merged commit 140f856 into Zapper-fi:main Jun 24, 2022
@SamIam-0x
Copy link
Contributor

Hello @singlefinance !

Looks like you did not provide an address when submitting your PR. I recognize it may have seemed kind of random that we were asking for a wallet address with a PR submission, but we are actually looking for ways to reward Studio contributors in the future.

Is there an address you’d want to provide? Could even be an empty address, if you do not have an doxxed address

Let me know! Also, if you’d like to privately provide it, feel free to shoot me a TG https://t.me/SamIAm_0x or DM on the Zapper Discord.

Thanks!
Sam

@SamIam-0x
Copy link
Contributor

Gentle ping on this @singlefinance !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants