Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

fix(positions): Move cache registration logic to position service #745

Merged
merged 1 commit into from
Jun 23, 2022
Merged

fix(positions): Move cache registration logic to position service #745

merged 1 commit into from
Jun 23, 2022

Conversation

immasandwich
Copy link
Contributor

Description

In the PositionFetcherRegistry initialization logic, register the getPositions method to the CacheOnIntervalService. This aligns the decorator with what we have in production so we don't double register the job.

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

@immasandwich immasandwich merged commit 66dd3ae into main Jun 23, 2022
@immasandwich immasandwich deleted the only-register-cache-on-interval-within-studio branch June 23, 2022 20:41
@zapper-bot zapper-bot mentioned this pull request Jun 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JForsaken JForsaken JForsaken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@immasandwich @JForsaken