-
Notifications
You must be signed in to change notification settings - Fork 381
feat(rubicon): Add Rubicon.finance and Rubicon Bath Tokens #922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good sers! Great first contribution. A few comments to fix, then we can ship it. Please also add a logo to src/apps/rubicon/assets/logo.png
…es+secondary label
Thank you so much for the swift review @immasandwich. I have resolved all of your comments and added our logo in d56197a. Please let me know what else I can do to be helpful or what we should do to accelerate the process. Thanks again 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing, can you rename rubicon.bathToken.token-fetcher.ts
to rubicon.bath-token.token-fetcher.ts
? We specifically kebab-case the group in file names.
No problem! Resolved in ae10227 - please lmk if there's anything else I can do to be helpful 😄 |
Thank you @immasandwich, quick question: can we use custom logos for Bath Tokens on the platform? For example, if we provided custom logos like those found here, could they populate in Zapper? It seems most projects do not do this so just wanted to ask. Thank you again and we will have a follow-up PR for you that improves our implementation to a more scalable state, with a capitalized "r" in Rubicon. |
Description
This is an initial PR to initialize Rubicon as a Zapper project. We are excited to integrate with Zapper and this PR represents a basic implementation that tracks Bath Tokens and their underlying value; the same way we do in our app.
Checklist
bghughes.eth
@_benjaminhughes
How to test?
A sanity check on the ERC-20 Bath Token balances can be performed via Etherscan as all contracts are verified on-chain and audited. Please see a list of all the mainnet Bath Tokens here.
Future Works
The storing of Bath Token addresses will be overhauled to be dynamic at the protocol level (and here when fetching as presently a hardcoded string array is used) in future updates. Moreover, in the next PR, we will incorporate custom logos and more information to improve the UX.
Please let me know if I can help the process or provide any additional information - we are pumped to be on Zapper!