This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
feat(rocket-pool): Add Rocket Pool staked ETH #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immasandwich
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the amount of ETH staked on the beacon chain by a node operator to the Rocket Pool app. It's shown next to the amount of RPL staked.
Node operators can launch minipools. Each minipool consists of 16 ETH from the node operator and another 16 ETH from the deposit pool. Therefore the amount of ETH staked by a node operator is the number of minipools times 16 ETH. This does not show accrued beacon chain rewards.
ETH in Eth2 Depositshown in theEthereum Stakingapp for Rocket Pool node operators is incorrect. It shows 64 ETH when it should be only 16 ETH. (Perhaps because there's 2 deposits and it assumes each deposit is 32 ETH.) So it should be hidden for Rocket Pool node operators.Checklist
How to test?