This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix: Correct Rubicon definition name, fix bath token decimal issues, and add labels #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es+secondary label
|
@bghughes looks like some merge conflicts? Merge in the latest from |
Great - thank you @immasandwich - I believe I resolved this in 0720674 - please let me know if any other changes are required 😄 |
immasandwich
approved these changes
Jul 23, 2022
volt62
pushed a commit
to volt62/zapper-studio
that referenced
this pull request
Aug 2, 2022
… issues, and add labels (Zapper-fi#933)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR correctly uppercases our project name, accounts for decimals on the Bath Tokens (bathUSDC + bathUSDT are not rendering due to this issue right now), and adds labels to our definition
Checklist
bghughes.eth@_benjaminhughesHow to test?
I verified this via
pnpm devand double checking the total supply values coming from these problem tokens we noticed (due to them not rendering).