Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long names cover the description in search results. #28

Open
Volbla opened this issue Sep 20, 2023 · 1 comment
Open

Long names cover the description in search results. #28

Volbla opened this issue Sep 20, 2023 · 1 comment

Comments

@Volbla
Copy link

Volbla commented Sep 20, 2023

dexlap

This is because utilitychart.css hardcodes the width of these columns. 120px for the name and 488px for the description. But that's not a showdown-dex file, it's a showdown-play file. Looking up how it affects the teambuilder's layout:

playlap

The difference comes from pokedex.css specifying .utilichart a { white-space: nowrap; }

The simplest fix for this is to make the description column float: right; instead. Though it wouldn't quite work in the teambuilder if the chat is closed and the description ends up on the other side of the screen. Another option would be to make this a proper table. The name-column would auto-size to the widest element, making the descriptions evenly offset from the left. I don't know if you can put a link around an entire row, but i'm sure that can be solved one way or another.

In either case, setting hard dimensions on variably sized content like text seems like a bad idea. I'd rather have some dynamic boxes if it means everything is readable.

@Zarel
Copy link
Owner

Zarel commented Nov 15, 2024

Honestly I don't particularly have an opinion on which looks better/worse. And for the ones with tables, like the pokemon with the stat tables, I'd rather have the stat tables line up than avoid overlap...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants