-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable the BlockVerifier continuous_blockchain_test #1011
Comments
@hdevalence, @yaahc I think the changes in #902 (comment) mainly affect this ticket, rather than PR #1012 #1012 changes the verifiers so they stop trying to handle out of order blocks themselves. This ticket makes the state handle those out of order blocks. |
I don't think we want a single queue, because the two queues are used in different places and contain disjoint data. Two queues would be a better fit. |
#1101 does not resolve this issue - those tests aren't enabled yet. |
Seems like this should have been closed by #1101 but wasn't? Closing manually, feel free to re-open if this is not the case |
Oops, just checked history, re-opening, sorry for the noise |
This task can't be done in the first alpha, because it depends on the refactor in #1135, which is long-term work. |
It seems like this test got removed or renamed a long while ago. |
To handle out of order blocks, we decided to implement a temporary out-of-order block cache in the state service, and disable some of the affected tests.
We need to re-enable these tests, once we have implemented the features they depend on.
TODO
zebra_consensus::chain::tests::continuous_blockchain_test
, which depends on contextual verification of post-Sapling blocks (after Refactor Network and NetworkUpgrade enums into structs and a trait #1135)Context
Temporarily ignore failing state tests
The text was updated successfully, but these errors were encountered: