Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable the BlockVerifier continuous_blockchain_test #1011

Closed
1 task
Tracked by #745
teor2345 opened this issue Sep 4, 2020 · 8 comments · Fixed by #1101
Closed
1 task
Tracked by #745

Re-enable the BlockVerifier continuous_blockchain_test #1011

teor2345 opened this issue Sep 4, 2020 · 8 comments · Fixed by #1101
Assignees
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@teor2345
Copy link
Contributor

teor2345 commented Sep 4, 2020

To handle out of order blocks, we decided to implement a temporary out-of-order block cache in the state service, and disable some of the affected tests.

We need to re-enable these tests, once we have implemented the features they depend on.

TODO

Context

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement E-med labels Sep 4, 2020
@teor2345 teor2345 changed the title make the state handle out of order blocks Make the state handle out of order blocks Sep 4, 2020
@teor2345
Copy link
Contributor Author

teor2345 commented Sep 8, 2020

@hdevalence, @yaahc I think the changes in #902 (comment) mainly affect this ticket, rather than PR #1012

#1012 changes the verifiers so they stop trying to handle out of order blocks themselves. This ticket makes the state handle those out of order blocks.

@hdevalence
Copy link
Contributor

I don't think we want a single queue, because the two queues are used in different places and contain disjoint data. Two queues would be a better fit.

@teor2345 teor2345 changed the title Make the state handle out of order blocks Test state handling for out of order blocks Oct 1, 2020
@teor2345 teor2345 modified the milestones: Sync and Network, State Service Oct 8, 2020
@teor2345
Copy link
Contributor Author

teor2345 commented Oct 8, 2020

#1101 does not resolve this issue - those tests aren't enabled yet.

@teor2345 teor2345 reopened this Oct 8, 2020
@teor2345 teor2345 modified the milestones: State Service, First Alpha Release Oct 8, 2020
@teor2345 teor2345 changed the title Test state handling for out of order blocks Re-enable the BlockVerifier continuous_blockchain_test Oct 26, 2020
@teor2345 teor2345 removed this from the First Alpha Release milestone Oct 26, 2020
@teor2345
Copy link
Contributor Author

Moved out-of-order transcripts to the state tracking issue #1049.
Moved sync tests to #1188.

The remaining work is out of scope for the first alpha.

@mpguerra
Copy link
Contributor

Seems like this should have been closed by #1101 but wasn't?

Closing manually, feel free to re-open if this is not the case

@mpguerra mpguerra reopened this Nov 12, 2020
@mpguerra
Copy link
Contributor

Oops, just checked history, re-opening, sorry for the noise

@teor2345
Copy link
Contributor Author

This task can't be done in the first alpha, because it depends on the refactor in #1135, which is long-term work.

@mpguerra mpguerra removed this from the Block Validation milestone Jan 5, 2021
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@teor2345
Copy link
Contributor Author

It seems like this test got removed or renamed a long while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants